Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to log stream selectors before service name detection #14154

Merged
merged 8 commits into from
Oct 2, 2024

Conversation

trevorwhitney
Copy link
Collaborator

What this PR does / why we need it:

Add the ability to debug service name detection by printing pushed streams before detection, along with the service name that will be used. As this will run per-push, it is guarded by the same log_push_request_streams tenant config we already have.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@trevorwhitney trevorwhitney marked this pull request as ready for review September 30, 2024 17:34
@trevorwhitney trevorwhitney requested a review from a team as a code owner September 30, 2024 17:34
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 30, 2024
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@trevorwhitney trevorwhitney merged commit d7ff426 into main Oct 2, 2024
60 checks passed
@trevorwhitney trevorwhitney deleted the log-stream-before-service-name branch October 2, 2024 15:17
trevorwhitney added a commit that referenced this pull request Oct 4, 2024
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants